Skip to content

Conversation

d-buchmann
Copy link
Contributor

@d-buchmann d-buchmann commented May 22, 2025

  • Changed "target" parameter type of handleAction in parts table controller to string
  • Sanitize input for existing actions which expect an int
  • Add tag (dummy) to SelectAPI
  • Add tag option to twig template

This is purely theory, nothing of this is tested yet!
When implemetation is done, this should solve #178.

Made "target" parameter of handleAction in parts table a string
Sanitize input for exisitng action which expect an int
Add tag (dummy) to SelectAPI
Add tag option to twig template
@mkne
Copy link
Contributor

mkne commented Oct 6, 2025

Hi @d-buchmann
any progress on this? I introduced part-db to a co-worker and we consider to use tags to label parts with RoHS and REACH compliance. So bulk editing of tags would come in handy for our existing 2000+ parts. Can I help with testing or something else?

@d-buchmann
Copy link
Contributor Author

d-buchmann commented Oct 7, 2025

Indeed I got a little further, but my lack of js skills is holding me back.
It feels like the solution is quite hacky all over the place =)
The worst thing is that all actions work with an "ID" of the target to be modified, but tags don't have one, so I abuse the ID parameter by putting in the tag verbatim.

I can add and remove tags by entering them in the selector field by hand. The search doesn't work yet.
If you try to remove a tag that doesn't exist, or click add when no tag is in the selector, nothing happens.
However this is only from my experience, not thoroughly tested. If you intend to test it, please do a full backup first :D
Note, this branch is still based on 1.x.

@d-buchmann d-buchmann changed the title Preparations for bulk editing of tags Allow bulk editing of tags Oct 7, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 36.58537% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.71%. Comparing base (e1418df) to head (6fd2bb9).

Files with missing lines Patch % Lines
src/Services/Parts/PartsTableActionHandler.php 16.66% 15 Missing ⚠️
src/Controller/SelectAPIController.php 0.00% 10 Missing ⚠️
src/Controller/PartListsController.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #940      +/-   ##
============================================
- Coverage     57.77%   57.71%   -0.07%     
- Complexity     7043     7054      +11     
============================================
  Files           565      565              
  Lines         23028    23058      +30     
============================================
+ Hits          13305    13308       +3     
- Misses         9723     9750      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants